On Thu, Dec 15, 2022 at 06:12:05PM +0000, Sean Christopherson wrote: > Nit, terminating punction (the period) isn't usually included in the shortlog. > > On Thu, Dec 15, 2022, Yu Zhang wrote: > > KVM already has a 'GPA_INVALID' defined as (~(gpa_t)0) in > > kvm_types.h, and it is used by ARM and X86 xen code. We do > > not need a specific definition of 'INVALID_GPA' for X86. > > > > Instead of using the common 'GPA_INVALID' for X86, replace > > the definition of 'GPA_INVALID' with 'INVALID_GPA', and > > change the users of 'GPA_INVALID', so that the diff can be > > smaller. Also because the name 'INVALID_GPA' tells the user > > we are using an invalid GPA, while the name 'GPA_INVALID' > > is emphasizing the GPA is an invalid one. > > > > Also, add definition of 'INVALID_GFN' because it is more > > proper than 'INVALID_GPA' for GFN variables. > > This should be a separate commit. Yes, it's trivial and a nop, but there's no > reason to surprise readers/blamers that assumed the shortlog tells the whole > story. E.g. add and use INVALID_GFN where appropriate in patch 1, then switch > to INVALID_GPA in patch 2. Then you can also add a "Suggested-by: David ..." for > patch 1. Good point! Thanks! :) B.R. Yu
