Re: [PATCH] KVM: X86: Use the common definition - 'GPA_INVALID' for X86

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Dec 13, 2022 at 05:52:20AM +0000, Sean Christopherson wrote:
> What if we rename GPA_INVALID to INVALID_GPA and modify _those_ users?  I have
> a slight preference for INVALID_GPA, and we also have INVALID_PAGE.  It'll also
> yield a smaller diff.
> 
> EVMPTR_INVALID is the counter argument, but that's more of an error code than a
> semi-arbitrary value, e.g. there's also EVMPTR_MAP_PENDING.
> 
> $ git grep GPA_INVALID | wc -l
> 17
> $ git grep INVALID_GPA | wc -l
> 55
> 

Good point. Thanks!

B.R.
Yu



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux