On Wed, Nov 9, 2022 at 11:28 AM Like Xu <like.xu.linux@xxxxxxxxx> wrote: > > On 28/10/2022 6:02 am, Sean Christopherson wrote: > >> Aaron Lewis (7): > >> kvm: x86/pmu: Correct the mask used in a pmu event filter lookup > >> kvm: x86/pmu: Remove impossible events from the pmu event filter > >> kvm: x86/pmu: prepare the pmu event filter for masked events > >> kvm: x86/pmu: Introduce masked events to the pmu event filter > >> selftests: kvm/x86: Add flags when creating a pmu event filter > >> selftests: kvm/x86: Add testing for KVM_SET_PMU_EVENT_FILTER > >> selftests: kvm/x86: Test masked events > > One comment request in the last patch, but it's not the end of the world if it > > doesn't get added right away. > > > > An extra set of eyeballs from Paolo, Jim, and/or Like would be welcome as I don't > > consider myself trustworthy when it comes to PMU code... > > > > Reviewed-by: Sean Christopherson<seanjc@xxxxxxxxxx> > > > > I'm not going to block these changes just because I don't use the > pmu-event-filter feature very heavily. > One of my concern is the relatively lower test coverage of pmu-event-filter > involved code, despite its predictable performance optimizations. Is there something else you are hoping to see as far as testing goes other than the selftest? Or is something missing in it? > > Maybe a rebase version would attract more attention (or at least mine). Sure, I'll send out v7 rebased on top of kvm/queue. > > Thanks, > Like Xu
