Re: [PATCH v6 0/7] Introduce and test masked events

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 28/10/2022 6:02 am, Sean Christopherson wrote:
Aaron Lewis (7):
   kvm: x86/pmu: Correct the mask used in a pmu event filter lookup
   kvm: x86/pmu: Remove impossible events from the pmu event filter
   kvm: x86/pmu: prepare the pmu event filter for masked events
   kvm: x86/pmu: Introduce masked events to the pmu event filter
   selftests: kvm/x86: Add flags when creating a pmu event filter
   selftests: kvm/x86: Add testing for KVM_SET_PMU_EVENT_FILTER
   selftests: kvm/x86: Test masked events
One comment request in the last patch, but it's not the end of the world if it
doesn't get added right away.

An extra set of eyeballs from Paolo, Jim, and/or Like would be welcome as I don't
consider myself trustworthy when it comes to PMU code...

Reviewed-by: Sean Christopherson<seanjc@xxxxxxxxxx>


I'm not going to block these changes just because I don't use the pmu-event-filter feature very heavily. One of my concern is the relatively lower test coverage of pmu-event-filter involved code, despite its predictable performance optimizations.

Maybe a rebase version would attract more attention (or at least mine).

Thanks,
Like Xu



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux