On Thu, Nov 03, 2022 at 09:04:23AM +0800, Robert Hoo wrote: > I also notice that skip_tlb_flush is set when pcid_enabled && (CR3 > & X86_CR3_PCID_NOFLUSH). Under this condition, do you think (0,0) --> > (1,0) need to flip it back to false? Yes, I think we should. We know it is a safe choice. It also would be nice to get LAM documentation updated on the expected behaviour. It is not clear from current documentation if enabling LAM causes flush. We can only guess that it should at least for some scenarios. Phantom TLB entires that resurface after LAM gets disable would be fun to debug. -- Kiryl Shutsemau / Kirill A. Shutemov
