On Wed, 2 Nov 2022 06:14:24 +0000 Anthony DeRossi <ajderossi@xxxxxxxxx> wrote: > On Tue, Nov 1, 2022 at 11:38 AM Jason Gunthorpe <jgg@xxxxxxxx> wrote: > > I've been meaning to take a deeper look, but I'm thinking vfio_pci > > doesn't need open_count at all any more. > > I spent some time looking at it, but I'm not very familiar with this > area. > > None of the fields in vfio_pci_core_device look usable as a substitute > for open_count, but calling pci_is_enabled() on the PCI device might be > sufficient. pci_enable_device()/pci_disable_device() appear to be called > in the right locations in vfio_pci_core. I think that could work too, but of course it's PCI specific. If we had a vfio core helper to get the open count for the device set, that would make it more universally available. Thanks, Alex
