Re: [PATCH v3 3/5] vfio: Move vfio_spapr_iommu_eeh_ioctl into vfio_iommu_spapr_tce.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Oct 17, 2022 at 11:06:19PM -0700, Christoph Hellwig wrote:
> > +	switch (op.op) {
> > +	case VFIO_EEH_PE_DISABLE:
> > +		ret = eeh_pe_set_option(pe, EEH_OPT_DISABLE);
> > +		break;
> > +	case VFIO_EEH_PE_ENABLE:
> > +		ret = eeh_pe_set_option(pe, EEH_OPT_ENABLE);
> > +		break;
> 
> This could be simplified a bit more by moving the return from the
> end of the function into the switch statements.

Yes, all the rets can go away

> > - * Copyright Gavin Shan, IBM Corporation 2014.
> 
> This notice needs to move over to vfio_iommu_spapr_tce.c.

Ok

Thanks,
Jason 



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux