On Mon, Oct 17, 2022 at 10:08:48PM +0000, Sean Christopherson wrote: > On Mon, Oct 17, 2022, Maciej S. Szmigiero wrote: > > > +#define MEM_EXTRA_SIZE 0x10000 > > > > Also, an expression like "(64 << 10)" is more readable than a "1" > > with a tail of zeroes (it's easy to add one zero too many or be one > > zero short). > > +1 to not open coding raw numbers. > > I think it's high time KVM selftests add #defines for the common sizes, e.g. SIZE_4KB, > 16KB, 64K, 2MB, 1GB, etc... > > Alternatively (or in addition), just #define 1KB, 1MB, 1GB, and 1TB, and then do > math off of those. I mean I love boilerplate as much as the next guy, but we can just use tools/include/linux/sizes.h -- Thanks, Oliver
