Re: [kvm-unit-tests PATCH v3 1/1] s390x: verify EQBS/SQBS is unavailable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





Am 24.08.22 um 09:40 schrieb Janosch Frank:
On 8/4/22 00:17, Thomas Huth wrote:
On 03/08/2022 15.58, Nico Boehr wrote:
QEMU doesn't provide EQBS/SQBS instructions, so we should check they
result in an exception.

I somewhat fail to see the exact purpose of this patch... QEMU still doesn't
emulate a lot of other instructions, too, so why are we checking now these
QBS instructions? Why not all the others? Why do we need a test to verify
that there is an exception in this case - was there a bug somewhere that
didn't cause an exception in certain circumstances?

Looking at the patch that introduced the QEMU handlers (1eecf41b) I wonder why those two cases were added. From my point of view it makes sense to remove the special handling for those two instructions.

@Christian: Any idea why this was added? Can we remove it?

No idea why it was added (in an always fail way). Yes we could remove it until we need it.



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux