On 24/08/2022 09.40, Janosch Frank wrote:
On 8/4/22 00:17, Thomas Huth wrote:
On 03/08/2022 15.58, Nico Boehr wrote:
QEMU doesn't provide EQBS/SQBS instructions, so we should check they
result in an exception.
I somewhat fail to see the exact purpose of this patch... QEMU still doesn't
emulate a lot of other instructions, too, so why are we checking now these
QBS instructions? Why not all the others? Why do we need a test to verify
that there is an exception in this case - was there a bug somewhere that
didn't cause an exception in certain circumstances?
Looking at the patch that introduced the QEMU handlers (1eecf41b) I wonder
why those two cases were added. From my point of view it makes sense to
remove the special handling for those two instructions.
Ah, there are handlers for these instructions in QEMU - that's what I was
missing. But I agree with you, these do not look very useful and should just
be dropped on the QEMU side.
Thomas
