> From: Jason Gunthorpe <jgg@xxxxxxxxxx> > Sent: Thursday, September 1, 2022 2:25 AM > > On Wed, Aug 31, 2022 at 12:02:31PM -0600, Alex Williamson wrote: > > > > The criteria I like to use is if the header is able to compile > > > stand-alone. > > > > Is this stream of consciousness or is there some tooling for this? ;) > > In my case I'm using clangd https://clangd.llvm.org/ in the editor, > which checks header files for self-consistency. > > But there is also https://include-what-you-use.org/ (though I have > never tried it) > > But the above wack of text is just the normal compiler invocation of > vfio_main.c with main.c replaced by the header. Thanks. This is a good learning. > > > > > btw while they are moved here the inclusions in vfio_main.c are > > > > not removed in patch8. > > > > > > ? I'm not sure I understand this > > > > I think Kevin is asking why these includes were not also removed from > > vfio_main.c when adding them to vfio.h. Thanks, yes > > Oh, I am actually unclear what is policy/preference/consensus in that > area. me either. That is why I raised this open in case there is already a consensus in place. 😊 > > I know a strong camp is to avoid implicit includes, so the duplicated > includes are welcomed. include-what-you-use for instance is that > philosophy. > > Do you have a preference? > > Jason
