> From: Jason Gunthorpe <jgg@xxxxxxxxxx>
> Sent: Wednesday, August 31, 2022 9:02 AM
>
> As is normal for headers.
>
> Signed-off-by: Jason Gunthorpe <jgg@xxxxxxxxxx>
> ---
> drivers/vfio/vfio.h | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/drivers/vfio/vfio.h b/drivers/vfio/vfio.h
> index 503bea6c843d56..093784f1dea7a9 100644
> --- a/drivers/vfio/vfio.h
> +++ b/drivers/vfio/vfio.h
> @@ -3,6 +3,14 @@
> * Copyright (C) 2012 Red Hat, Inc. All rights reserved.
> * Author: Alex Williamson <alex.williamson@xxxxxxxxxx>
> */
> +#ifndef __VFIO_VFIO_H__
> +#define __VFIO_VFIO_H__
> +
> +#include <linux/device.h>
> +#include <linux/cdev.h>
> +#include <linux/module.h>
Curious what is the criteria for which header inclusions should be
placed here. If it is for everything required by the definitions in
this file then the list is not complete, e.g. <linux/iommu.h> is
obviously missing.
btw while they are moved here the inclusions in vfio_main.c are
not removed in patch8.
> +
> +struct iommu_group;
>
> enum vfio_group_type {
> /*
> @@ -69,3 +77,5 @@ struct vfio_iommu_driver_ops {
>
> int vfio_register_iommu_driver(const struct vfio_iommu_driver_ops *ops);
> void vfio_unregister_iommu_driver(const struct vfio_iommu_driver_ops
> *ops);
> +
> +#endif
> --
> 2.37.2
