On Fri, Jul 22, 2022 at 02:53:20PM -0700, Ricardo Koller wrote: > > Which brings me to what to do with this test. Should it be fixed for > bare-metal by ignoring the PMOVSSET check? or should it actually check > for PMOVSSET=1 and fail on KVM until KVM gets fixed? > Hi Ricardo, Please write the test per the spec. Failures pointed out in kvm-unit-tests are great, when the tests are written correctly, since it means it's doing its job :-) If some CI somewhere starts blocking builds due to the failure, then there are ways to skip the test. Unfortunately the easiest way is usually the oversized hammer of skipping every unittests.cfg entry that fails. To do better, either the CI needs to be taught about all the subtest failures it can ignore or the test code needs some work to allow silencing known failures. For the test code, refactoring to isolate the test into it's own unittests.cfg entry and then skipping that entry is one way, but probably won't work in this case, since the overflow checks are scattered. Another way is to guard all the overflow checks with a variable which can be set with a command line parameter or environment variable. Eventually, when the KVM bug is fixed, the guard variable could be forced off for kernel versions >= the version the fix is merged. The kernel version can be detected in the unit test by looking at the KERNEL_* environment variables. Thanks, drew
