On 6/27/22 15:50, Kai Huang wrote: >> Are Kirill's magic 0/1/2 numbers the same as >> >> TDX_PG_4K, >> TDX_PG_2M, >> TDX_PG_1G, >> >> ? > Yes they are the same. Kirill uses 0/1/2 as input of TDX_ACCEPT_PAGE TDCALL. > Here I only need them to distinguish different page sizes. > > Do you mean we should put TDX_PG_4K/2M/1G definition to asm/tdx.h, and > try_accept_one() should use them instead of magic 0/1/2? I honestly don't care how you do it as long as the magic numbers go away (within reason).
