On 2022/6/24 22:05, Jason Gunthorpe wrote:
On Mon, Jun 20, 2022 at 01:54:59AM -0700, Yi Liu wrote:
No need to protect open_count with group_rwsem
You should explain why this is a good change as you did in the emails
here, and no cover letter required for single patches
Fixes: 421cfe6596f6 ("vfio: remove VFIO_GROUP_NOTIFY_SET_KVM")
Extra space after fixes line.
No Fixes line for things that are not bugs.
cc: Matthew Rosato <mjrosato@xxxxxxxxxxxxx>
cc: Jason Gunthorpe <jgg@xxxxxxxxxx>
Cc:
Signed-off-by: Yi Liu <yi.l.liu@xxxxxxxxx>
---
drivers/vfio/vfio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
It seems OK but a bit unnecessary.
thanks, Jason. all good suggestions.I'd just want to see the
device->dev_set->lock and the group_rwsem hold/release is
symmetric in the case of err_undo_count is hit in the vfio_device_open().
Just like the order in vfio_device_fops_release().
--
Regards,
Yi Liu
