Re: [Patch 1/1] vfio: Move "device->open_count--" out of group_rwsem in vfio_device_open()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jun 20, 2022 at 01:54:59AM -0700, Yi Liu wrote:
> No need to protect open_count with group_rwsem

You should explain why this is a good change as you did in the emails
here, and no cover letter required for single patches
 
> Fixes: 421cfe6596f6 ("vfio: remove VFIO_GROUP_NOTIFY_SET_KVM")
> 

Extra space after fixes line.
No Fixes line for things that are not bugs.

> cc: Matthew Rosato <mjrosato@xxxxxxxxxxxxx>
> cc: Jason Gunthorpe <jgg@xxxxxxxxxx>

Cc:

> Signed-off-by: Yi Liu <yi.l.liu@xxxxxxxxx>
> ---
>  drivers/vfio/vfio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

It seems OK but a bit unnecessary.

Jason



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux