Re: [PATCH v2 07/10] vfio/ccw: Create an OPEN FSM Event

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




As for the IDLE/CP_PROCESSING/CP_PENDING cases, going fsm_notoper
because this is unexpected probably makes sense, but the logging is
going to be really confusing (before this change, you know that you
called fsm_notoper because you got VFIO_CCW_EVENT_NOT_OPER -- now
you'll
see a log entry cut for NOT_OPER but won't be sure if it was for
EVENT_NOT_OPER or EVENT_OPEN).  Maybe you can look at 'event' inside
fsm_notoper and cut a slightly different trace entry when arriving
here
for EVENT_OPEN?

Yeah, good idea. Since we don't expect any of these in normal behavior,
perhaps I'll trace both state and event, instead of trying to make
conditionals out of everything.


Sounds good to me




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux