Re: [PATCH] KVM: mark segments accessed on HW task switch

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 01/25/2010 02:24 PM, Gleb Natapov wrote:
On Mon, Jan 25, 2010 at 01:12:36PM +0200, Avi Kivity wrote:
On 01/25/2010 01:11 PM, Gleb Natapov wrote:
On Mon, Jan 25, 2010 at 01:08:13PM +0200, Avi Kivity wrote:
On 01/25/2010 12:01 PM, Gleb Natapov wrote:
On HW task switch newly loaded segments should me marked as accessed.

@@ -4775,6 +4766,11 @@ int kvm_load_segment_descriptor(struct kvm_vcpu *vcpu, u16 selector,
  			kvm_seg.unusable = 1;

  	kvm_set_segment(vcpu,&kvm_seg, seg);
+	if (selector&&    !kvm_seg.unusable&&    kvm_seg.s) {
+		/* mark segment as accessed */
+		seg_desc.type |= 1;
+		save_guest_segment_descriptor(vcpu, selector,&seg_desc);
+	}
  	return 0;
  }
What about an error return from s_g_s_d?

What can or should we do about it?

If -EFAULT, propagate to userspace.

We don't handle it anywhere in task switch emulation. Separate patch?


Things like 'return kvm_write_guest_virt()' do handle it.

--
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux