Re: [PATCH 2/2] kvm-unit-tests: configure changes for illumos.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, May 27, 2022 at 10:41 AM Sean Christopherson <seanjc@xxxxxxxxxx> wrote:
> On Thu, May 26, 2022, Dan Cross wrote:
> > On Thu, May 26, 2022 at 5:23 PM Sean Christopherson <seanjc@xxxxxxxxxx> wrote:
> > > Why not simply move the check to run_tests.sh?  I can't imaging it's performance
> > > sensitive, and I doubt I'm the only one that builds tests on one system and runs
> > > them on a completely different system.
> >
> > `run_tests.sh` already has the test. Changing it to a warning here
> > was at the suggestion of Thomas and Drew.
>
> Ah, hence the earlier comment about removing the check entirely.  Either works
> for me, thanks!

Thanks for the helpful comments on the review!

        - Dan C.



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux