Re: [PATCH 2/2] kvm-unit-tests: configure changes for illumos.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, May 26, 2022 at 5:23 PM Sean Christopherson <seanjc@xxxxxxxxxx> wrote:
> In the future, please tag each new posting with a version number, e.g. no version
> number for the first posting, than v2, v3, v4, etc... for each subsequent posting.
> It took me a while to figure what was what.

Ah, sorry about that. Sure thing.

> On Thu, May 26, 2022, Dan Cross wrote:
> > Warn, don't fail, if the check for `getopt -T` fails in the `configure`
> > script.
> >
> > Aside from this check, `configure` does not use `getopt`, so don't
> > fail to run if `getopt -T` doesn't indicate support for  the extended
> > Linux version.  Getopt is only used in `run_tests.sh`, which tests for
> > extended getopt anyway, but emit a warning here.
>
> Why not simply move the check to run_tests.sh?  I can't imaging it's performance
> sensitive, and I doubt I'm the only one that builds tests on one system and runs
> them on a completely different system.

`run_tests.sh` already has the test. Changing it to a warning here
was at the suggestion of Thomas and Drew.

        - Dan C.



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux