> > > +#ifdef CONFIG_TDX > > > +bool is_tdx_vm(void); > > > +#else > > > +#define is_tdx_vm() 0 > > > > Just add that to the tdx-stubs.c file you already created in one of the > > previous patches and drop this #ifdef mess ;) > > This is for consistency with SEV. Anyway Either way is okay. > From target/i386/sev.h > ... > #ifdef CONFIG_SEV > bool sev_enabled(void); > bool sev_es_enabled(void); > #else > #define sev_enabled() 0 > #define sev_es_enabled() 0 > #endif Hmm, not sure why sev did it this way. One possible reason is that the compiler optimizer can see sev_enabled() evaluates to 0 and throw away the dead code branches then. So, yes, maybe it makes sense to stick to the #ifdef in this specific case. take care, Gerd
