On Mon, May 23, 2022 at 10:48:17AM +0200, Gerd Hoffmann <kraxel@xxxxxxxxxx> wrote: > > diff --git a/target/i386/kvm/tdx.h b/target/i386/kvm/tdx.h > > index c8a23d95258d..4036ca2f3f99 100644 > > --- a/target/i386/kvm/tdx.h > > +++ b/target/i386/kvm/tdx.h > > @@ -1,6 +1,10 @@ > > #ifndef QEMU_I386_TDX_H > > #define QEMU_I386_TDX_H > > > > +#ifndef CONFIG_USER_ONLY > > +#include CONFIG_DEVICES /* CONFIG_TDX */ > > +#endif > > + > > #include "exec/confidential-guest-support.h" > > > > #define TYPE_TDX_GUEST "tdx-guest" > > @@ -16,6 +20,12 @@ typedef struct TdxGuest { > > uint64_t attributes; /* TD attributes */ > > } TdxGuest; > > > > +#ifdef CONFIG_TDX > > +bool is_tdx_vm(void); > > +#else > > +#define is_tdx_vm() 0 > > Just add that to the tdx-stubs.c file you already created in one of the > previous patches and drop this #ifdef mess ;) This is for consistency with SEV. Anyway Either way is okay. >From target/i386/sev.h ... #ifdef CONFIG_SEV bool sev_enabled(void); bool sev_es_enabled(void); #else #define sev_enabled() 0 #define sev_es_enabled() 0 #endif -- Isaku Yamahata <isaku.yamahata@xxxxxxxxx>