On 5/18/2022 1:32 AM, Alex Williamson wrote: > On Tue, 17 May 2022 15:32:19 +0530 > Abhishek Sahu <abhsahu@xxxxxxxxxx> wrote: >> diff --git a/drivers/vfio/pci/vfio_pci_core.c b/drivers/vfio/pci/vfio_pci_core.c >> index 4fe9a4efc751..5ea1b3099036 100644 >> --- a/drivers/vfio/pci/vfio_pci_core.c >> +++ b/drivers/vfio/pci/vfio_pci_core.c >> @@ -156,7 +156,7 @@ static void vfio_pci_probe_mmaps(struct vfio_pci_core_device *vdev) >> } >> >> struct vfio_pci_group_info; >> -static bool vfio_pci_dev_set_try_reset(struct vfio_device_set *dev_set); >> +static void vfio_pci_dev_set_try_reset(struct vfio_device_set *dev_set); >> static int vfio_pci_dev_set_hot_reset(struct vfio_device_set *dev_set, >> struct vfio_pci_group_info *groups); >> >> @@ -275,6 +275,19 @@ void vfio_pci_lock_and_set_power_state(struct vfio_pci_core_device *vdev, >> up_write(&vdev->memory_lock); >> } >> >> +#ifdef CONFIG_PM > > Neither of the CONFIG_PM checks added are actually needed afaict, both > struct dev_pm_ops and the pm pointer on struct device_driver are defined > regardless. Thanks, > > Alex > Yes. These are not needed for build. I will remove these explicit CONFIG_PM checks. Regards, Abhishek
