Marcelo Tosatti <mtosatti@xxxxxxxxxx> wrote:
> Otherwise memory beyond irq_states[16] might be accessed.
>
> Noticed by Juan Quintela.
>
> Signed-off-by: Marcelo Tosatti <mtosatti@xxxxxxxxxx>
>
> diff --git a/virt/kvm/irq_comm.c b/virt/kvm/irq_comm.c
> index 9b07734..9fd5b3e 100644
> --- a/virt/kvm/irq_comm.c
> +++ b/virt/kvm/irq_comm.c
> @@ -302,6 +302,7 @@ static int setup_routing_entry(struct kvm_irq_routing_table *rt,
> {
> int r = -EINVAL;
> int delta;
> + unsigned max_pin;
> struct kvm_kernel_irq_routing_entry *ei;
> struct hlist_node *n;
>
> @@ -322,12 +323,15 @@ static int setup_routing_entry(struct kvm_irq_routing_table *rt,
> switch (ue->u.irqchip.irqchip) {
> case KVM_IRQCHIP_PIC_MASTER:
> e->set = kvm_set_pic_irq;
> + max_pin = 16;
once you are here, you can use the constant name:
PIC_NUM_PINS
Humm, that is not going to fly, it is defined in x86 code, and it is
used in generic code.
No great ideas here :(
> break;
> case KVM_IRQCHIP_PIC_SLAVE:
> e->set = kvm_set_pic_irq;
> + max_pin = 16;
> delta = 8;
> break;
> case KVM_IRQCHIP_IOAPIC:
> + max_pin = KVM_IOAPIC_NUM_PINS;
> e->set = kvm_set_ioapic_irq;
> break;
> default:
> @@ -335,7 +339,7 @@ static int setup_routing_entry(struct kvm_irq_routing_table *rt,
> }
> e->irqchip.irqchip = ue->u.irqchip.irqchip;
> e->irqchip.pin = ue->u.irqchip.pin + delta;
> - if (e->irqchip.pin >= KVM_IOAPIC_NUM_PINS)
> + if (e->irqchip.pin >= max_pin)
> goto out;
> rt->chip[ue->u.irqchip.irqchip][e->irqchip.pin] = ue->gsi;
> break;
For the rest, patch fixes my concerns.
Acked-by: Juan Quintela <quintela@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
