On Fri, Apr 15, 2022 at 09:13:43AM -0300, Jason Gunthorpe wrote: > On Fri, Apr 15, 2022 at 06:47:31AM +0200, Christoph Hellwig wrote: > > On Thu, Apr 14, 2022 at 03:46:01PM -0300, Jason Gunthorpe wrote: > > > Use IS_ENABLED and static inlines instead of just ifdef'ing away all the > > > PPC code. This allows it to be compile tested on all platforms and makes > > > it easier to maintain. > > > > That's even uglier than what we had. I'd rather have a new vfio_ppc.c > > to implement it, then you can stubs for it in the header (or IS_ENABLED > > if you really want) but we don't need stubs for ppc-specific arch > > functionality in a consumer of it. > > That seems like a good approach, I will try it Actually, it defeats the whole point of this patch. I wrote it so I could compile test all this stuff on x86 - if I shift it into a vfio_ppc.c and make some kconfig stuff then it still won't compile test on x86. At that point I'd rather leave the ifdefs as-is and drop this patch. Yes, the #ifdef is ugly, but this whole PPC thing is ugly :\ Jason
