On Fri, Apr 15, 2022 at 06:47:31AM +0200, Christoph Hellwig wrote: > On Thu, Apr 14, 2022 at 03:46:01PM -0300, Jason Gunthorpe wrote: > > Use IS_ENABLED and static inlines instead of just ifdef'ing away all the > > PPC code. This allows it to be compile tested on all platforms and makes > > it easier to maintain. > > That's even uglier than what we had. I'd rather have a new vfio_ppc.c > to implement it, then you can stubs for it in the header (or IS_ENABLED > if you really want) but we don't need stubs for ppc-specific arch > functionality in a consumer of it. That seems like a good approach, I will try it Thanks, Jason
