> > > > > The reason code set is meant to provide hypervisors with their own > > > > > termination SEV-ES Guest-Hypervisor Communication Block > > > > > Standardization reason codes. This document defines and owns reason > > > > > code set 0x0 and the following reason codes (GHCBData[23:16]): > > > > > 0x00 – General termination request > > > > > 0x01 – SEV-ES / GHCB Protocol range is not supported. > > > > > 0x02 – SEV-SNP features not supported > > > > > > > > Reading this again, I now see that "reason_set" sounds like "The > > > > reason code is set". I bet that's how Sean read it during his review. > > > > So yeah, this needs comments :-)! > > > > > > I'll add comments but I agree with Marc. These are part of the GHCB > > > spec so for the very specific SEV-ES termination reason we should > > > include all the data the spec allows. Sounds OK? > > > > Ugh, so "set" means "set of reason codes"? That's heinous naming. I don't have a > > strong objection to splitting, but at the same time, why not punt it to userspace? > > Userspace is obviously going to have to understand what the hell "set" means > > anyways... > > I am fine just copying the entire MSR to userspace. I'm fine with it too. Thanks for the feedback, Sean!
