On Wed, Mar 23, 2022 at 04:37:50PM +0100, Niklas Schnelle wrote: > > +/* > > + * This holds a pinned page list for multiple areas of IO address space. The > > + * pages always originate from a linear chunk of userspace VA. Multiple > > + * io_pagetable's, through their iopt_area's, can share a single iopt_pages > > + * which avoids multi-pinning and double accounting of page consumption. > > + * > > + * indexes in this structure are measured in PAGE_SIZE units, are 0 based from > > + * the start of the uptr and extend to npages. pages are pinned dynamically > > + * according to the intervals in the users_itree and domains_itree, npages > > + * records the current number of pages pinned. > > This sounds wrong or at least badly named. If npages records the > current number of pages pinned then what does npinned record? Oh, it is a typo, the 2nd npages should be npinned, thanks Jason