Re: [patch 00/11] convert slotslock to SRCU v2

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Saturday 26 December 2009 00:27:11 Avi Kivity wrote:
> On 12/25/2009 02:25 PM, Marcelo Tosatti wrote:
> >> One small comment on the naming:
> >>
> >> kvm->memslots->memslots[i]
> >> kvm->aliases->aliases[i]
> >>
> >> Doesn't look good...
> >
> > Hi Sheng,
> >
> > Yes its somewhat confusing but i could not come up with
> > anything better. Suggestions?
> 
> Could all it 'mem', and put both ->memslots and ->aliases as members.
> This might simplify things a bit.
> 
> However, I don't recommend doing so now, it's just churn.  We can always
> to it later.
 
Yes. Just happen to see it, and feel a little uneasy... :)

-- 
regards
Yang, Sheng

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux