On Thu, Mar 03, 2022, Peter Gonda wrote: > On Thu, Mar 3, 2022 at 9:26 AM Sean Christopherson <seanjc@xxxxxxxxxx> wrote: > > Ha, we've already got a lovely workaround for exactly this problem. This patch > > should drop the include from svm_onhyperv.c, there's nothing in that file that > > needs kvm_cache_regs.h (I verified by deleting use of is_guest_mode()), it's > > included purely because of this bug in svm.h. > > Ah good catch. I assume I should add kvm_cache_regs.h to > arch/x86/kvm/svm/nested.c too since it uses is_guest_mode(). Nah, picking it up from svm.h (and several other headers) is ok. If we required every compilation unit to _directly_ include every header, we'd probably double the size of the kernel source :-)
