On 2/1/22 2:21 PM, Peter Gonda wrote:
+ /* smoke-test the secrets page passed */ + if (!info.secrets_phys || info.secrets_len != PAGE_SIZE) + return 0;This seems like an error condition worth noting. If no cc_blob_address is passed it makes sense not to log but what if the address passed fails this smoke test, why not log?
If the smoke test fails, there will not be the /dev/sev-guest device, and userspace should log it accordingly. Having said so, I am not against logging if it helps.
thanks
