On Wed, Jan 19, 2022, Aaron Lewis wrote: > > > > > diff --git a/x86/unittests.cfg b/x86/unittests.cfg > > > index 9fcdcae..0353b69 100644 > > > --- a/x86/unittests.cfg > > > +++ b/x86/unittests.cfg > > > @@ -368,6 +368,13 @@ arch = x86_64 > > > groups = vmx nested_exception > > > check = /sys/module/kvm_intel/parameters/allow_smaller_maxphyaddr=Y > > > > > > +[vmx_exception_test] > > > +file = vmx.flat > > > +extra_params = -cpu max,+vmx -append vmx_exception_test > > > +arch = x86_64 > > > +groups = vmx nested_exception > > > +timeout = 10 > > > > Why add a new test case instead of folding this into "vmx"? It's quite speedy. > > The "vmx" bucket definitely needs some cleanup, but I don't thinking adding a bunch > > of one-off tests is the way forward. > > > > I'm not sure I follow. The test does run in the "vmx" bucket > AFAICT... Oh, do you mean it should be added to the extra_params here > along with the other tests? Yep, exactly. "vmx" really needs to be split up and/or reworked so that it's command line isn't so ridiculous, but that's a future problem.
