Re: [kvm-unit-tests PATCH v2 3/4] x86: Add a test framework for nested_vmx_reflect_vmexit() testing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



>
> > diff --git a/x86/unittests.cfg b/x86/unittests.cfg
> > index 9fcdcae..0353b69 100644
> > --- a/x86/unittests.cfg
> > +++ b/x86/unittests.cfg
> > @@ -368,6 +368,13 @@ arch = x86_64
> >  groups = vmx nested_exception
> >  check = /sys/module/kvm_intel/parameters/allow_smaller_maxphyaddr=Y
> >
> > +[vmx_exception_test]
> > +file = vmx.flat
> > +extra_params = -cpu max,+vmx -append vmx_exception_test
> > +arch = x86_64
> > +groups = vmx nested_exception
> > +timeout = 10
>
> Why add a new test case instead of folding this into "vmx"?  It's quite speedy.
> The "vmx" bucket definitely needs some cleanup, but I don't thinking adding a bunch
> of one-off tests is the way forward.
>

I'm not sure I follow.  The test does run in the "vmx" bucket
AFAICT... Oh, do you mean it should be added to the extra_params here
along with the other tests?

[vmx]
file = vmx.flat
extra_params = -cpu max,+vmx -append "-exit_monitor_from_l2_test
-ept_access* -vmx_smp* -vmx_vmcs_shadow_test
-atomic_switch_overflow_msrs_test -vmx_init_signal_test
-vmx_apic_passthrough_tpr_threshold_test -apic_reg_virt_test
-virt_x2apic_mode_test -vmx_pf_exception_test -vmx_pf_no_vpid_test
-vmx_pf_invvpid_test -vmx_pf_vpid_test"
arch = x86_64
groups = vmx

>
> > +
> >  [debug]
> >  file = debug.flat
> >  arch = x86_64
> > diff --git a/x86/vmx.c b/x86/vmx.c
> > index f4fbb94..9908746 100644
> > --- a/x86/vmx.c
> > +++ b/x86/vmx.c
> > @@ -1895,6 +1895,23 @@ void test_set_guest(test_guest_func func)
>



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux