On Mon, Dec 13, 2021 at 10:59:14PM +0000, David Matlack wrote: > When dirty logging is enabled without initially-all-set, attempt to > split all huge pages in the memslot down to 4KB pages so that vCPUs > do not have to take expensive write-protection faults to split huge > pages. > > Huge page splitting is best-effort only. This commit only adds the > support for the TDP MMU, and even there splitting may fail due to out > of memory conditions. Failures to split a huge page is fine from a > correctness standpoint because we still always follow it up by write- > protecting any remaining huge pages. One more thing: how about slightly document the tlb flush skipping behavior in commit message, or, in the function to do the split? I don't see any problem with it but I'm just not sure whether it's super obvious to anyone. -- Peter Xu