On Thu, Jan 06, 2022, David Matlack wrote: > > Nit, to be consistent with the kernel, s/huge page/hugepage. > > The kernel seems pretty split on which to use actually: > > $ git grep --extended "huge[ _]page" | wc -l > 1663 > $ git grep --extended "hugepage" | wc -l > 1558 > > The former has a slight edge so I went with that throughout the series. Ha, and KVM leans even more heavily huge_page. huge_page it is. > > > + > > > +static bool > > > > Please put the return type and attributes on the same line as the function name, > > splitting them makes grep sad. > > Sure will do. Out of curiosity, what sort of workflow expects to be > able to grep the return type, attributes, and function name on the > same line? Start here[*], there are several good examples further down that thread. [*] https://lore.kernel.org/all/CAHk-=wjS-Jg7sGMwUPpDsjv392nDOOs0CtUtVkp=S6Q7JzFJRw@xxxxxxxxxxxxxx
