Re: [PATCH] KVM: Fix possible circular locking in kvm_vm_ioctl_assign_device()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Dec 07, 2009 at 04:58:04PM +0800, Sheng Yang wrote:
> One possible order is:
> 
> KVM_CREATE_IRQCHIP ioctl(took kvm->lock) -> kvm_iobus_register_dev() ->
> down_write(kvm->slots_lock).
> 
> The other one is in kvm_vm_ioctl_assign_device(), which take kvm->slots_lock
> first, then kvm->lock.
> 
> Observe it due to kernel locking debug warnings.

Sheng,

Looks good.

Can you also update the comment on top of kvm_main.c?

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux