On Mon, Dec 06, 2021 at 03:37:43PM +0000, Sean Christopherson wrote: > On Mon, Dec 06, 2021, Ameer Hamza wrote: > > If undefined ioctl number is passed to the kvm_vcpu_ioctl_device_attr > > function, it should return with error status. > > No, if anything KVM should do KVM_BUG_ON() and return -EIO, because @ioctl is > completely KVM controlled. But I'd personally prefer we leave it as is, there's > one call site that very clearly invokes the helper with only the three ioctls. > It's not a strong preference though. Thank you for your response. I agree with you, but I think in my opinion, it would be nice to resolve coverity warning. Let me update the patch according to your suggestions anyway. Thanks, Hamza.
