Re: [PATCH 11/11] KVM: x86/xen: Add KVM_IRQ_ROUTING_XEN_EVTCHN and event channel delivery

[Paolo Bonzini <pbonzini@xxxxxxxxxx>]

On 11/15/21 17:50, David Woodhouse wrote:
> +			asm volatile("1:\t" LOCK_PREFIX "orq %0, %1\n"
> +				     "\tnotq %0\n"
> +				     "\t" LOCK_PREFIX "andq %0, %2\n"
> +				     "2:\n"
> +				     "\t.section .fixup,\"ax\"\n"
> +				     "3:\tjmp\t2b\n"
> +				     "\t.previous\n"
> +				     _ASM_EXTABLE_UA(1b, 3b)
> +				     : "=r" (evtchn_pending_sel)
> +				     : "m" (vi->evtchn_pending_sel),
> +				       "m" (v->arch.xen.evtchn_pending_sel),

These need to be "+m", I think?

And same for st->preempted actually.

Paolo

> +				       "0" (evtchn_pending_sel));