On Thu, Nov 4, 2021 at 2:39 PM Reiji Watanabe <reijiw@xxxxxxxxxx> wrote: > > Hi Oliver, > > On Thu, Nov 4, 2021 at 9:14 AM Oliver Upton <oupton@xxxxxxxxxx> wrote: > > > > Hi Reiji, > > > > On Tue, Nov 02, 2021 at 11:24:54PM -0700, Reiji Watanabe wrote: > > > Extend sys_regs[] of kvm_cpu_context for ID registers and save ID > > > registers' sanitized value in the array for the vCPU at the first > > > vCPU reset. Use the saved ones when ID registers are read by > > > userspace (via KVM_GET_ONE_REG) or the guest. > > > > Based on my understanding of the series, it appears that we require the > > CPU identity to be the same amongst all vCPUs in a VM. Is there any > > value in keeping a single copy in kvm_arch? > > Yes, that's a good point. > It reminded me that the idea bothered me after we discussed a similar > case about your counter offset patches, but I didn't seriously > consider that. Yeah, it was a good suggestion for the counter offsetting series, and one that I plan to adopt once I get back to that set :) -- Thanks, Oliver
