On Wed, Nov 3, 2021 at 1:00 PM Sean Christopherson <seanjc@xxxxxxxxxx> wrote: > > On Wed, Nov 03, 2021, Vipin Sharma wrote: > > This check will be done in switch statement of kvm_handle_invpcid(), > > Please make the changelog a stand on its own, i.e. don't rely on the shortlog > for context. > > > used by both VMX and SVM. It also removes (type > 3) check. > > Use imperative mood, i.e. state what you're doing as a "command", don't refer to > the patch from a third-person point of view. > > The changelog also needs to call out that, unlike INVVPID and INVEPT, INVPCID is > not explicitly documented as checking the "type" before reading the operand from > memory. I.e. there's a subtle, undocumented functional change in this patch. > > Something like: > > Handle #GP on INVCPID due to an invalid type in the common switch statement > instead of relying on callers to manually verify the type is valid. Unlike > INVVPID and INVPET, INVPCID is not explicitly documented as checking the type > before reading the operand from memory, so deferring the type validity check > until after that point is architecturally allowed. > Thanks. I will update it and send out v3. > For the code: > > Reviewed-by: Sean Christopherson <seanjc@xxxxxxxxxx>
