Re: [PATCH kvm-unit-tests 1/2] unify structs for GDT descriptors

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 20/10/21 19:58, Sean Christopherson wrote:
Changelog says "unify struct", yet gdt_entry_t and gdt_desc_entry_t have fully
redundant information.  Apparently anonymous structs aren't a thing (or I'm just
doing it wrong), but even so, fully unifying this is not hugely problematic for
the sole consumer.

Right, the unification is more between 32- and 64 bits.

"Unifying" the reply to both patches, the best thing to do is:

- always use gdt_entry_t as the argument

- use your definition of gdt_desc_entry_t and call it gdt_system_desc_entry_t.

- read the type and, if needed, cast to gdt_system_desc_entry_t to "OR" in the base4 field.

Paolo




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux