On Tue, Sep 21, 2021 at 9:44 AM Andrew Jones <drjones@xxxxxxxxxx> wrote: > > On Fri, Aug 27, 2021 at 03:12:07AM +0000, Zixuan Wang wrote: > > From: Varad Gautam <varad.gautam@xxxxxxxx> > > > > This commit implements helper functions that call UEFI services and > > assist the boot up process. > > > > Signed-off-by: Varad Gautam <varad.gautam@xxxxxxxx> > > --- > > lib/efi.c | 58 +++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 58 insertions(+) > > create mode 100644 lib/efi.c > > > > diff --git a/lib/efi.c b/lib/efi.c > > new file mode 100644 > > index 0000000..9711354 > > --- /dev/null > > +++ b/lib/efi.c > > @@ -0,0 +1,58 @@ > > +#include <linux/uefi.h> > > Please add at least an SPDX header. Got it, I will add one in the next version. > > + status = efi_bs_call(get_memory_map, &map_size, > > + NULL, &key, &desc_size, NULL); > > + if (status != EFI_BUFFER_TOO_SMALL || map_size == 0) > > + goto out; > > + > > + /* Pad map_size with additional descriptors so we don't need to > > + * retry. */ > > nit: please use Linux comment style Got it! I will update the comment style in the next version > > + return 0; > > +} > > -- > > 2.33.0.259.gc128427fd7-goog > > > > Otherwise > > Reviewed-by: Andrew Jones <drjones@xxxxxxxxxx> > Thank you! Best regards, Zixuan
