On Tue, Sep 21, 2021 at 9:33 AM Andrew Jones <drjones@xxxxxxxxxx> wrote: > > On Fri, Aug 27, 2021 at 03:12:06AM +0000, Zixuan Wang wrote: > > From: Varad Gautam <varad.gautam@xxxxxxxx> > > > > Copy UEFI-related definitions from Linux, so the follow-up commits can > > develop UEFI function calls based on these definitions, without relying > > on GNU-EFI library. > > > > Signed-off-by: Varad Gautam <varad.gautam@xxxxxxxx> > > --- > > lib/linux/uefi.h | 518 +++++++++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 518 insertions(+) > > create mode 100644 lib/linux/uefi.h > > > > diff --git a/lib/linux/uefi.h b/lib/linux/uefi.h > > new file mode 100644 > > index 0000000..567cddc > > --- /dev/null > > +++ b/lib/linux/uefi.h > > Any reason to rename this to uefi.h even though it's efi.h in Linux? This file is from Varad's patch set [1]. I can rename the file to efi.h in the next version if Varad is OK with it. [1] https://lore.kernel.org/kvm/20210819113400.26516-1-varad.gautam@xxxxxxxx/ > Usually I'd suggest we take the whole file from Linux (but that would > be a mess for this one, so no) or that we only take what we need, when > we need it, rather than dumping a bunch of stuff up front which may or > may not be needed. Skimming through though, it looks like we'll likely > need most the stuff brought over. So I guess I'm OK with this approach. > > Thanks, > drew Thank you for the detailed explanation! Another reason to keep this a separate commit is to preserve Varad's full authorship of these 2 commits. We already re-organized Varad's 6 patches into these 2, and do not want to further reduce Varad's authorships. Best regards, Zixuan
