On 10/29/2009 10:34 AM, Chris Lalancette wrote:
I'm starting to take a look at this. While this may be a generically useful cleanup, it occurs to me that even if we call "set_irq" from the hrtimer callback, we still have to do the "kick_vcpus" type thing. Otherwise, we still have the problem where if all vcpus are idle, none of them will be doing vcpu_run anytime soon to actually inject the interrupt into the guest. Or did I mis-understand what you are proposing?
The pic and ioapic code will kick vcpus that they deliver interrupts to, that's the natural order of things. It was the kick from the timer (which is only connected indirectly to vcpus via the pic/ioapic) which is hacky and special.
As a bonus, if the interrupt is masked, no vcpus will be kicked. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
