> On Tue, Oct 20, 2009 at 08:40:26AM +0900, Avi Kivity wrote: > > On 10/17/2009 04:27 AM, Glauber Costa wrote: > >> This is a patch actually written by Juan, which, according to him, > >> he plans on posting to qemu.git. Problem is that linux defines > >> u64 in a way that is type-uncompatible with uint64_t. > >> > >> I am including it here, because it is a dependency to my patch series > >> that follows. > >> > >> > > > > Why can't we store these values in qemu as uint64_ts? > Because then we have to redefine the whole structure in qemu. > > the proposal is to simply pick the structures directly from linux. I believe > it is much easier, and the versioning scheme in vmstate will help us get > around any changes they might suffer in the future. I get build errors with this. Is there something extra I need to do? I am currently running a rhel54 2.6.18 kernel. CC qdev-properties.o savevm.c: In function ‘get_u64’: savevm.c:856: error: ‘__u64’ undeclared (first use in this function) savevm.c:856: error: (Each undeclared identifier is reported only once savevm.c:856: error: for each function it appears in.) savevm.c:856: error: ‘v’ undeclared (first use in this function) savevm.c: In function ‘put_u64’: savevm.c:863: error: ‘__u64’ undeclared (first use in this function) savevm.c:863: error: ‘v’ undeclared (first use in this function) make[1]: *** [savevm.o] Error 1 make[1]: *** Waiting for unfinished jobs.... make: *** [build-all] Error 2 Thanks, -Andrew -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html