On Tue, Jun 15, 2021 at 10:20:49AM -0600, Alex Williamson wrote: > On Tue, 15 Jun 2021 12:04:58 -0300 > Jason Gunthorpe <jgg@xxxxxxxxxx> wrote: > > > On Tue, Jun 15, 2021 at 09:00:29AM -0600, Alex Williamson wrote: > > > > > "vfio" override in PCI-core plays out for other override types. Also I > > > don't think dynamic IDs should be handled uniquely, new_id_store() > > > should gain support for flags and userspace should be able to add new > > > dynamic ID with override-only matches to the table. Thanks, > > > > Why? Once all the enforcement is stripped out the only purpose of the > > new flag is to signal a different prepration of modules.alias - which > > won't happen for the new_id path anyhow > > Because new_id allows the admin to insert a new pci_device_id which has > been extended to include a flags field and intentionally handling > dynamic IDs differently from static IDs seems like generally a bad > thing. I'd agree with you if there was a functional difference at runtime, but since that was all removed, I don't think we should touch new_id. This ends up effectively being only a kbuild related patch that changes how modules.alias is built. Jason
