On Tue, 15 Jun 2021 12:04:58 -0300 Jason Gunthorpe <jgg@xxxxxxxxxx> wrote: > On Tue, Jun 15, 2021 at 09:00:29AM -0600, Alex Williamson wrote: > > > "vfio" override in PCI-core plays out for other override types. Also I > > don't think dynamic IDs should be handled uniquely, new_id_store() > > should gain support for flags and userspace should be able to add new > > dynamic ID with override-only matches to the table. Thanks, > > Why? Once all the enforcement is stripped out the only purpose of the > new flag is to signal a different prepration of modules.alias - which > won't happen for the new_id path anyhow Because new_id allows the admin to insert a new pci_device_id which has been extended to include a flags field and intentionally handling dynamic IDs differently from static IDs seems like generally a bad thing. For example, maybe the admin wants to specify nouveau as only an override match for all 10de: class vga devices. Thanks, Alex
