On Wed, Jun 09, 2021 at 02:49:32AM +0000, Tian, Kevin wrote: > Last unclosed open. Jason, you dislike symbol_get in this contract per > earlier comment. As Alex explained, looks it's more about module > dependency which is orthogonal to how this contract is designed. What > is your opinion now? Generally when you see symbol_get like this it suggests something is wrong in the layering.. Why shouldn't kvm have a normal module dependency on drivers/iommu? Jason