On Wed, 9 Jun 2021 at 13:52, Paolo Bonzini <pbonzini@xxxxxxxxxx> wrote: > > On 09/06/21 04:15, Wanpeng Li wrote: > > On Wed, 9 Jun 2021 at 00:27, Paolo Bonzini <pbonzini@xxxxxxxxxx> wrote: > > [...] > >> Perhaps instead set TMCCT to 0 in kvm_apic_set_state, instead of keeping > >> the value that was filled in by KVM_GET_LAPIC? > > > > Keeping the value that was filled in by KVM_GET_LAPIC is introduced by > > commit 24647e0a39b6 (KVM: x86: Return updated timer current count > > register from KVM_GET_LAPIC), could you elaborate more? :) > > KVM_GET_LAPIC stores the current value of TMCCT and KVM_SET_LAPIC's > memcpy stores it in vcpu->arch.apic->regs. KVM_SET_LAPIC perhaps could > store zero in vcpu->arch.apic->regs after it uses it, and then the > stored value would always be zero. Just do it in a new version, thanks. :) Wanpeng
