On Tue, Apr 06, 2021 at 04:40:24PM -0300, Jason Gunthorpe wrote: > These should always be prefixed with static, otherwise compilation > will fail on non-modular builds with > > ld: samples/vfio-mdev/mbochs.o:(.data+0x2e0): multiple definition of `mdev_type_attr_name'; samples/vfio-mdev/mdpy.o:(.data+0x240): first defined here > > Fixes: a5e6e6505f38 ("sample: vfio bochs vbe display (host device for bochs-drm)") > Fixes: d61fc96f47fd ("sample: vfio mdev display - host device") > Signed-off-by: Jason Gunthorpe <jgg@xxxxxxxxxx> Looks good, Reviewed-by: Christoph Hellwig <hch@xxxxxx>